Revert "Handle stateful order replacement in Ender (#1667)"

This reverts commit 2446abf.
dydxprotocol · Jul 12, 2024 · 5f24c33 · 5f24c33
1 parent 1725612
commit 5f24c33
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 441 deletions.
diff --git a/...vices/ender/__tests__/handlers/stateful-order/conditional-order-placement-handler.test.ts b/...vices/ender/__tests__/handlers/stateful-order/conditional-order-placement-handler.test.ts
@@ -45,7 +45,7 @@ import { producer } from '@dydxprotocol-indexer/kafka';
 import { ConditionalOrderPlacementHandler } from '../../../src/handlers/stateful-order/conditional-order-placement-handler';
 import { createPostgresFunctions } from '../../../src/helpers/postgres/postgres-functions';
 
-describe('conditional-order-placement-handler', () => {
+describe('conditionalOrderPlacementHandler', () => {
   beforeAll(async () => {
     await dbHelpers.migrate();
     await createPostgresFunctions();

diff --git a/...vices/ender/__tests__/handlers/stateful-order/conditional-order-triggered-handler.test.ts b/...vices/ender/__tests__/handlers/stateful-order/conditional-order-triggered-handler.test.ts
@@ -39,7 +39,7 @@ import { ConditionalOrderTriggeredHandler } from '../../../src/handlers/stateful
 import { defaultPerpetualMarket } from '@dydxprotocol-indexer/postgres/build/__tests__/helpers/constants';
 import { createPostgresFunctions } from '../../../src/helpers/postgres/postgres-functions';
 
-describe('conditional-order-triggered-handler', () => {
+describe('conditionalOrderTriggeredHandler', () => {
   beforeAll(async () => {
     await dbHelpers.migrate();
     await createPostgresFunctions();

diff --git a/...services/ender/__tests__/handlers/stateful-order/stateful-order-placement-handler.test.ts b/...services/ender/__tests__/handlers/stateful-order/stateful-order-placement-handler.test.ts
@@ -45,7 +45,7 @@ import { producer } from '@dydxprotocol-indexer/kafka';
 import { ORDER_FLAG_LONG_TERM } from '@dydxprotocol-indexer/v4-proto-parser';
 import { createPostgresFunctions } from '../../../src/helpers/postgres/postgres-functions';
 
-describe('stateful-order-placement-handler', () => {
+describe('statefulOrderPlacementHandler', () => {
   beforeAll(async () => {
     await dbHelpers.migrate();
     await createPostgresFunctions();

diff --git a/...r/services/ender/__tests__/handlers/stateful-order/stateful-order-removal-handler.test.ts b/...r/services/ender/__tests__/handlers/stateful-order/stateful-order-removal-handler.test.ts
@@ -38,7 +38,7 @@ import { STATEFUL_ORDER_ORDER_FILL_EVENT_TYPE } from '../../../src/constants';
 import { producer } from '@dydxprotocol-indexer/kafka';
 import { createPostgresFunctions } from '../../../src/helpers/postgres/postgres-functions';
 
-describe('stateful-order-removal-handler', () => {
+describe('statefulOrderRemovalHandler', () => {
   beforeAll(async () => {
     await dbHelpers.migrate();
     await createPostgresFunctions();

diff --git a/...rvices/ender/__tests__/handlers/stateful-order/stateful-order-replacement-handler.test.ts b/...rvices/ender/__tests__/handlers/stateful-order/stateful-order-replacement-handler.test.ts
diff --git a/indexer/services/ender/__tests__/helpers/constants.ts b/indexer/services/ender/__tests__/helpers/constants.ts
@@ -448,20 +448,6 @@ export const defaultLongTermOrderPlacementEvent: StatefulOrderEventV1 = {
   },
 };
 
-export const defaultStatefulOrderReplacementEvent: StatefulOrderEventV1 = {
-  orderReplacement: {
-    oldOrderId: defaultOrderId2,
-    order: {
-      ...defaultMakerOrder,
-      orderId: {
-        ...defaultMakerOrder.orderId!,
-        orderFlags: ORDER_FLAG_LONG_TERM,
-      },
-      goodTilBlockTime: 123,
-    },
-  },
-};
-
 export const defaultTradingRewardsEvent: TradingRewardsEventV1 = {
   tradingRewards: [
     {

diff --git a/indexer/services/ender/__tests__/validators/stateful-order-validator.test.ts b/indexer/services/ender/__tests__/validators/stateful-order-validator.test.ts
@@ -18,7 +18,6 @@ import {
   defaultOrderId,
   defaultStatefulOrderPlacementEvent,
   defaultStatefulOrderRemovalEvent,
-  defaultStatefulOrderReplacementEvent,
   defaultTime,
   defaultTxHash,
 } from '../helpers/constants';
@@ -43,7 +42,6 @@ describe('stateful-order-validator', () => {
       ['conditional order placement', defaultConditionalOrderPlacementEvent],
       ['conditional order triggered', defaultConditionalOrderTriggeredEvent],
       ['long term order placement', defaultLongTermOrderPlacementEvent],
-      ['stateful order replacement', defaultStatefulOrderReplacementEvent],
     ])('does not throw error on valid %s', (_message: string, event: StatefulOrderEventV1) => {
       const validator: StatefulOrderValidator = new StatefulOrderValidator(
         event,
@@ -61,7 +59,7 @@ describe('stateful-order-validator', () => {
         'does not contain any event',
         {},
         'One of orderPlace, orderRemoval, conditionalOrderPlacement, ' +
-        'conditionalOrderTriggered, longTermOrderPlacement, orderReplacement must be defined in StatefulOrderEvent',
+        'conditionalOrderTriggered, longTermOrderPlacement must be defined in StatefulOrderEvent',
       ],
 
       // TODO(IND-334): Remove tests after deprecating StatefulOrderPlacement events