Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Remove Valid Host Check as it does not cover all Domains #55

Open
dunklesToast opened this issue Jun 24, 2020 · 0 comments
Open

Remove Valid Host Check as it does not cover all Domains #55

dunklesToast opened this issue Jun 24, 2020 · 0 comments

Comments

@dunklesToast
Copy link
Contributor

I get the idea of the check but it actually prevents a user from using Hostnames, that are valid.
For example german company "Märklin" has the domain märklin.de which is totally valid and has an SSL certificate but your regex does not allow it.
Also, there are a lot of other special characters which are allowed on certain hostnames but not in your regex making the package kind of useless.
After a small local test I'd remove the test completely since Node just threws ENOTFOUND if the host does not exist.

dunklesToast added a commit to dunklesToast/ssl-checker that referenced this issue Jun 24, 2020
The check does not work properly and node has excellent error handling itself.
dyaa pushed a commit that referenced this issue Sep 23, 2020
The check does not work properly and node has excellent error handling itself.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant