Encourage following standard Rails upgrade process #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a [standard process][standard-process] to follow when bumping Rails by a minor or major version. Without following this, apps can end up with the version of Rails they're running being out of sync with their config, database schema, and the defaults that get loaded We already require approval for major version bumps to any package; this should additionally make approval required for minor Rails bumps Note that this only affects apps using the internal config - our default config requires approval for all minor bumps [standard-process]: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#the-upgrade-process
This should add a note to the PR body for major and minor Rails upgrades to remind developers to follow the [standard Rails upgrade process][standard-process] [standard-process]: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#the-upgrade-process
yndajas
force-pushed
the
dont-automerge-minor-rails
branch
from
7a8cd70 to
8f0fae0
Compare
jacksonj04
approved these changes
Jan 29, 2025
It only occurred to me to look for that option when beginning to write in the commit message that devs would still need to remember to do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended to follow the standard upgrade process when bumping Rails by a minor or major version
This updates our Renovate config to:
An example of an app that's missed changes because of automerging minor Rails upgrades: https://github.com/dxw/ruby-developer-worksim-template/pull/151 (see the second, third, and fourth commits)