-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aickeditor button to toolbars #13
Conversation
WalkthroughThe recent changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (5)
- recipes/dxpr_cms_basic_html_editor/composer.json (1 hunks)
- recipes/dxpr_cms_basic_html_editor/config/editor.editor.basic_html.yml (1 hunks)
- recipes/dxpr_cms_basic_html_editor/recipe.yml (1 hunks)
- recipes/dxpr_cms_full_html_editor/composer.json (1 hunks)
- recipes/dxpr_cms_full_html_editor/recipe.yml (1 hunks)
Additional comments not posted (5)
recipes/dxpr_cms_full_html_editor/recipe.yml (1)
8-8
: LGTM! Ensure proper integration of the new dependency.The addition of
ai_ckeditor
looks good. Verify that the integration of this new dependency is tested and documented.recipes/dxpr_cms_full_html_editor/composer.json (1)
9-9
: LGTM! Ensure proper integration of the new dependency.The addition of
drupal/ai
looks good. Verify that the integration of this new dependency is tested and documented.recipes/dxpr_cms_basic_html_editor/composer.json (1)
9-9
: LGTM! Ensure proper integration of the new dependency.The addition of
drupal/ai
looks good. Verify that the integration of this new dependency is tested and documented.recipes/dxpr_cms_basic_html_editor/recipe.yml (1)
9-9
: Dependency Addition:ai_ckeditor
The addition of
ai_ckeditor
as a dependency is a good enhancement to integrate AI-assisted features into the HTML editor.recipes/dxpr_cms_basic_html_editor/config/editor.editor.basic_html.yml (1)
28-28
: Toolbar Setting Addition:aickeditor
The addition of
aickeditor
to the toolbar settings is a good enhancement to integrate additional features into the HTML editor.
Closing this until we have a better user experience in CKEditor with AI |
Linked issues
Solution
BRIEFLY DESCRIBE YOUR PULL REQUEST HERE
Expected Failures
In Editor BS3
In Anonymous BS3
In Editor BS5
In Anonymous BS5
QA Tests
QA Tests Changes
CI/CD
To run the QA tests write a new comment as follows:
/qa-demo-2x-bs3-tests
/qa-demo-2x-bs5-tests
Checklist
Summary by CodeRabbit
New Features
drupal/ai
andai_ckeditor
to support advanced functionalities.Configuration Updates
aickeditor
plugin for improved editing options.