Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aickeditor button to toolbars #13

Closed
wants to merge 1 commit into from

Conversation

jjroelofs
Copy link
Contributor

@jjroelofs jjroelofs commented Aug 7, 2024

Linked issues

  • #PUT_ISSUE_NUMBER_HERE

Solution

BRIEFLY DESCRIBE YOUR PULL REQUEST HERE

Expected Failures

In Editor BS3

In Anonymous BS3

In Editor BS5

In Anonymous BS5

QA Tests

QA Tests Changes

CI/CD

To run the QA tests write a new comment as follows:

  • BS3
    /qa-demo-2x-bs3-tests
  • BS5
    /qa-demo-2x-bs5-tests

Checklist

  • I have read the CONTRIBUTING.md document.
  • My commit messages follow the contributing standards and style of this project.
  • My code follows the coding standards and style of this project.
  • My code contains no changes that are outside the scope of the issue.
  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • Need to run update.php after code changes.
  • Requires a change to end-user documentation.
  • Requires a change to developer documentation.
  • Requires a change to QA tests.
  • Requires a new QA test.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Summary by CodeRabbit

  • New Features

    • Integrated AI capabilities into both the basic and full HTML editors, enhancing content generation and editing features.
    • Added new dependencies for drupal/ai and ai_ckeditor to support advanced functionalities.
  • Configuration Updates

    • Updated editor settings to include the aickeditor plugin for improved editing options.

Copy link

coderabbitai bot commented Aug 7, 2024

Walkthrough

The recent changes to the dxpr_cms_basic_html_editor and dxpr_cms_full_html_editor projects primarily involve the addition of AI capabilities. Both projects now include a dependency on the drupal/ai package, enhancing their functionality with features like content generation and automated suggestions. Additionally, the ai_ckeditor dependency has been added to both recipes, indicating an integration of AI-assisted editing within the CKEditor setup.

Changes

Files Change Summary
recipes/dxpr_cms_basic_html_editor/composer.json, recipes/dxpr_cms_full_html_editor/composer.json Added dependency on drupal/ai with version ^1.0 while maintaining existing drupal/linkit dependency.
recipes/dxpr_cms_basic_html_editor/config/editor.editor.basic_html.yml Added new entry - aickeditor to the settings section to enhance editor functionality.
recipes/dxpr_cms_basic_html_editor/recipe.yml, recipes/dxpr_cms_full_html_editor/recipe.yml Added - ai_ckeditor as a new dependency in the install section to integrate AI capabilities in the editor.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 915691d and 8e95b71.

Files selected for processing (5)
  • recipes/dxpr_cms_basic_html_editor/composer.json (1 hunks)
  • recipes/dxpr_cms_basic_html_editor/config/editor.editor.basic_html.yml (1 hunks)
  • recipes/dxpr_cms_basic_html_editor/recipe.yml (1 hunks)
  • recipes/dxpr_cms_full_html_editor/composer.json (1 hunks)
  • recipes/dxpr_cms_full_html_editor/recipe.yml (1 hunks)
Additional comments not posted (5)
recipes/dxpr_cms_full_html_editor/recipe.yml (1)

8-8: LGTM! Ensure proper integration of the new dependency.

The addition of ai_ckeditor looks good. Verify that the integration of this new dependency is tested and documented.

recipes/dxpr_cms_full_html_editor/composer.json (1)

9-9: LGTM! Ensure proper integration of the new dependency.

The addition of drupal/ai looks good. Verify that the integration of this new dependency is tested and documented.

recipes/dxpr_cms_basic_html_editor/composer.json (1)

9-9: LGTM! Ensure proper integration of the new dependency.

The addition of drupal/ai looks good. Verify that the integration of this new dependency is tested and documented.

recipes/dxpr_cms_basic_html_editor/recipe.yml (1)

9-9: Dependency Addition: ai_ckeditor

The addition of ai_ckeditor as a dependency is a good enhancement to integrate AI-assisted features into the HTML editor.

recipes/dxpr_cms_basic_html_editor/config/editor.editor.basic_html.yml (1)

28-28: Toolbar Setting Addition: aickeditor

The addition of aickeditor to the toolbar settings is a good enhancement to integrate additional features into the HTML editor.

@jjroelofs
Copy link
Contributor Author

Closing this until we have a better user experience in CKEditor with AI

@jjroelofs jjroelofs closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant