Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Serverless #72

Merged
merged 3 commits into from
Oct 23, 2020
Merged

bump Serverless #72

merged 3 commits into from
Oct 23, 2020

Conversation

pberthonneau
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Online DevOps Dojo?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Workflow change
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • Lint passes locally with my changes.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@pberthonneau pberthonneau requested a review from a team as a code owner October 22, 2020 13:19
Copy link
Contributor

@tom-halpin tom-halpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pberthonneau thank you

@tom-halpin tom-halpin merged commit a7eb1a5 into master Oct 23, 2020
@tom-halpin tom-halpin deleted the serverless branch October 23, 2020 21:50
@pberthonneau
Copy link
Contributor Author

@tom-halpin I'm not sure what should be the triggers but 2 runs of check links is one too many.

Maybe
on:
push:
branches-ignore: master

@tom-halpin
Copy link
Contributor

@pberthonneau given that the master branch is protected that should work as direct commits to master are prevented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants