Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select bottom border line is very thin(thick) compare to date and input components #369

Open
apallamreddy opened this issue Jun 9, 2021 · 13 comments

Comments

@apallamreddy
Copy link

Describe the bug
The select bottom border line is vert thin(thick) compare to other components date & input
Expected behavior
the select bottom border should be same tick as other components(date & input )
Screenshots
Screenshot (152)
Screenshot (154)

@mchaudhary5
Copy link

Please provide ETC for this issue.

mawelCaballero added a commit that referenced this issue Jun 17, 2021
[Patch] Fix #369 Input text border line thickness
@apallamreddy
Copy link
Author

Can you conform in which version this issue is fixed We have updated the Version to 3.0.3 but still getting the issue. when screen is 100%
Screenshot (180)

@mawelCaballero
Copy link
Contributor

mawelCaballero commented Jun 22, 2021

Fix done in "@dxc-technology/halstack-angular": "3.0.4"

@aidamag
Copy link
Contributor

aidamag commented Jun 22, 2021

@apallamreddy
Copy link
Author

Hi @lisa159 ,
I have installed latest version 3.0.4 but still issue exit can you check in different resolution 100,90,110 you can see the issue
Screenshot (192)
Screenshot (193)
Screenshot (194)

@Jialecl Jialecl reopened this Jun 22, 2021
@Jialecl
Copy link
Collaborator

Jialecl commented Jun 22, 2021

Hello @apallamreddy ,

You are right, when zooming in the underlines do look different.
A new fix is on the way.

mawelCaballero added a commit that referenced this issue Jun 22, 2021
@mawelCaballero
Copy link
Contributor

@Jialecl has been working on it and it has been fixes in this "next" version.
@dxc-technology/[email protected]

Can you test it and give us feedback? In case of your feedback is positive a new release version will be created.

@apallamreddy
Copy link
Author

Hi @Jialecl ,
After installing latest next version components like input,data & select, are state behaving entirely differently (Not working fine
Screenshot (214)
Screenshot (215)
Screenshot (216)
)

@jsardid
Copy link
Member

jsardid commented Jun 23, 2021

I don't know what you mean by "not working fine". Can you be more specific?

Have in mind that if you are upgrading from another major version, there might be breaking changes in the components' API. We are following semver and you can find the changelog here:
https://github.com/dxc-technology/halstack-angular/releases

@apallamreddy
Copy link
Author

Hi @jsardid ,
You can see in The screen shot I have attached which is circled select bottom line is tick for same select fields not for all select field even though they are same component we use CDK Select , same for input field
Screenshot (216)_LI

@jsardid
Copy link
Member

jsardid commented Jun 23, 2021

@apallamreddy
This is only happening with some screen resolutions.
We are looking into it.

@jsardid jsardid reopened this Jun 23, 2021
@mchaudhary5
Copy link

What is the suggested resolution.

@jsardid
Copy link
Member

jsardid commented Jun 24, 2021

After talking to @apallamreddy, we have realised that this issue only happens if the user has rescaling enabled in the OS or in the browser.

Since:

  • The impact of the issue is low: in the unlikely scenario of a user with rescaling enabled, the issue only consists in the bottom line of some of the input fields being displayed 1px thicker.
  • Fixing it will take a considerable amount of time (we are not even sure of how to fix it right now), since this is related to underlying material fields using decimal pixels.
  • We are about to re-implement the inputs from scratch in the following weeks, with new designs and without material, which will fix the issue.

We have decided not to fix it right now and wait for the re-implementation that will happen the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants