-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noassignees #72
Noassignees #72
Conversation
defp error_message(login) do | ||
""" | ||
@#{login} the issue doesn't have anymore assignees but is still `in-progress`. | ||
Please assign a user to this issue or remove the `in-progress` label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message error might not be the best one, any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab we should put all error messages in a central place so they can easily be edited. (doesn't have to be done now, but in future...)
For now we should update it to:
"""
:warning: @#{login} issue has **no assignee** but is still `in-progress`. Who is working on it?
Please assign a user to this issue or remove the `in-progress` label. Thanks! :heart:
"""
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 89.28% 93.15% +3.86%
==========================================
Files 12 14 +2
Lines 56 73 +17
==========================================
+ Hits 50 68 +18
+ Misses 6 5 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab looks good. agree copy should be updated on error/warning message.
otherwise happy to merge. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should have a list of all errors in one place.
Looks good 👍
At the moment the messages are linked to their rule. Agree that we need to create a config file for the rules. I'd like to allow users to create their own rule for each of their repositories so it will make sense to refactor the error message with this feature |
to be merged after #70
see #71
add rule when assignee is removed from an issue but the
in-progress
label is still on.