Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noassignees #72

Merged
merged 2 commits into from
Jun 15, 2017
Merged

Noassignees #72

merged 2 commits into from
Jun 15, 2017

Conversation

SimonLab
Copy link
Member

to be merged after #70

see #71
add rule when assignee is removed from an issue but the in-progress label is still on.

defp error_message(login) do
"""
@#{login} the issue doesn't have anymore assignees but is still `in-progress`.
Please assign a user to this issue or remove the `in-progress` label.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message error might not be the best one, any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab we should put all error messages in a central place so they can easily be edited. (doesn't have to be done now, but in future...)

For now we should update it to:

"""
:warning: @#{login} issue has **no assignee** but is still `in-progress`. Who is working on it?
 Please assign a user to this issue or remove the `in-progress` label. Thanks! :heart:
"""

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #72 into master will increase coverage by 3.86%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   89.28%   93.15%   +3.86%     
==========================================
  Files          12       14       +2     
  Lines          56       73      +17     
==========================================
+ Hits           50       68      +18     
+ Misses          6        5       -1
Impacted Files Coverage Δ
web/controllers/event_controller.ex 100% <100%> (ø) ⬆️
web/controllers/processes/wait.ex 100% <100%> (ø) ⬆️
web/controllers/rules/rules.ex 100% <100%> (+33.33%) ⬆️
web/controllers/rules/issue/inprogress.ex 100% <100%> (ø)
web/controllers/rules/issue/noassignees.ex 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98107c...445788b. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. agree copy should be updated on error/warning message.
otherwise happy to merge. 👍

@nelsonic nelsonic removed their assignment Jun 15, 2017
Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should have a list of all errors in one place.

Looks good 👍

@SimonLab
Copy link
Member Author

At the moment the messages are linked to their rule. Agree that we need to create a config file for the rules. I'd like to allow users to create their own rule for each of their repositories so it will make sense to refactor the error message with this feature

@samhstn samhstn merged commit 862738f into master Jun 15, 2017
@samhstn samhstn deleted the noassignees branch June 15, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants