Feature/uri_parsing

[arronmabrey]

@dwbutler This PR impliments uri_config parsing as discussed here #19

[dwbutler]

Thanks, looks great!

There are a few things I would modify.

1. I think the URI should be passed in as an options hash like any other option, i.e. uri: 'unix://tmp/socket'
2. I think it would be good to automatically read in configuration from a LOGSTASH_URI environment variable, if present.

[arronmabrey]

@dwbutler Okay great, I can do those updates.

[arronmabrey]

I made the update from accepting the raw url "udp://localhost:5228" to a uri parameter {uri: "udp://localhost:5228"}

I had one question about the ENV['LOGSTASH_URI']. What should have higher precedence?
e.g.

uri = ENV['LOGSTASH_URI'] || opts[:uri]

or

uri = opts[:uri] || ENV['LOGSTASH_URI']

[dwbutler]

Hm... I think I would expect options passed in to take precedence over the environment. (option number 2)

[arronmabrey]

I think I actually prefer not having the environment variable hardcoded into the gem. I would rather use the new uri_parsing feature like this instead.

LogStashLogger::Device.new(uri: ENV['LOGSTASH_URI'])

This way the user has the flexibility to determine their own fallback policy.

For example in our production environment we want ENV['LOGSTASH_URI'] to take precedence.
Additionally, as side note, we already have a differently named environment variable ENV['SMCC_LOGGING_URL'] that would require each server to be updated.

All this is leading me to believe, it's better left up to the user to define the needed behavior.

This uri_parsing feature handles all heavy lifting and allows them to just simply pass an environment URL directly into the constructor, which I think is the big win here.

-- Arron

[dwbutler]

That makes sense. Only the user really knows what environment variable they want to store configuration in. Besides, you might have multiple logstash configurations defined.

[dwbutler]

One more thing - if the URI is invalid, it should probably just raise the exception so the problem is easier to notice and fix. I would be confused if my URI configuration were silently ignored and the default device were configured instead.

[arronmabrey]

@dwbutler Yah, I think you're right. PR is updated with that change.

[dwbutler]

Awesome, thanks!