Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rounded corners #307

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

marriaga158
Copy link
Contributor

@marriaga158 marriaga158 commented Jan 6, 2024

Added corner radius as a setting as well as default rounding for Windows 11 and MacOS

I only have a Windows 10 machine available to me for development, so testing on those OSes should be done to confirm default rounding is functioning as intended

Implements planned feature https://github.com/dvx/lofi/projects/5#card-90705511

@stamoun
Copy link
Collaborator

stamoun commented Jan 9, 2024

Thanks a lot for taking the time to do this!

I should be able to have a look at your PR this week.

@stamoun
Copy link
Collaborator

stamoun commented Jan 9, 2024

I noticed another issue (other than the bars and menu buttons disappearing).
When I switched to one of my other monitors on my Mac, the transparent background was white as follows:

image

Not sure if it's a Mac only issue (haven't tested on windows).
I don't think it's a showstopper for this feature though. I'd create a new issue for that.

@stamoun
Copy link
Collaborator

stamoun commented Jan 9, 2024

Good stuff though, I like the rounded corners! 🤗

@marriaga158
Copy link
Contributor Author

image

Updated with the suggested changes, there's still a lingering issue where on larger sizes the corner radius can clip the menu buttons. Going to investigate if there's a way to automatically move them inwards as a solution

@stamoun stamoun merged commit 862a498 into dvx:master Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants