Fix validation bug with ~

dvlpp · Nov 3, 2015 · f2e666d · f2e666d
1 parent bb2ccf9
commit f2e666d
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 2 deletions.
diff --git a/resources/views/cms/partials/formField.blade.php b/resources/views/cms/partials/formField.blade.php
@@ -1,6 +1,6 @@
 @if(!in_array($field->type, ["hidden", "javascript"]))
 
-    <div class="form-group sharp-field sharp-field-{{ $field->type }} sf-{{ $key }} col-md-{{ $field->field_width ?: '12' }}"
+    <div class="form-group sharp-field sharp-field-{{ $field->type }} {{ key_name_for_form_field($key) }} col-md-{{ $field->field_width ?: '12' }}"
 
         {{ $field->conditional_display ? 'data-conditional_display='.$field->conditional_display : '' }} >
 

diff --git a/src/Dvlpp/Sharp/Http/EntityController.php b/src/Dvlpp/Sharp/Http/EntityController.php
@@ -4,6 +4,7 @@
 
 use Dvlpp\Sharp\Exceptions\InvalidStateException;
 use Dvlpp\Sharp\Repositories\SharpCmsRepository;
+use Illuminate\Contracts\Support\MessageBag;
 use Illuminate\Http\Request;
 use Dvlpp\Sharp\Config\SharpConfig;
 use Illuminate\Contracts\Auth\Access\Gate;
@@ -344,6 +345,8 @@ private function save($categoryName, $entityName, Request $request, $id)
             ], 200);
 
         } catch (ValidationException $e) {
+            $this->formatValidationErrors($e->getErrors());
+
             return response()->json($e->getErrors(), 422);
         }
     }
@@ -385,4 +388,20 @@ private function fireEvent($entityConfig, $eventName, $params)
         }
     }
 
+    /**
+     * Format validation errors, handling ~ special case.
+     *
+     * @param MessageBag $validationErrors
+     */
+    private function formatValidationErrors(MessageBag $validationErrors)
+    {
+        $errors = [];
+        foreach($validationErrors->keys() as $key) {
+            $errors[str_replace("~", "-", $key)] = $validationErrors->get($key);
+        }
+        if(count($errors)) {
+            $validationErrors->merge($errors);
+        }
+    }
+
 }
diff --git a/src/Dvlpp/Sharp/Validation/SharpValidator.php b/src/Dvlpp/Sharp/Validation/SharpValidator.php
@@ -1,4 +1,6 @@
-<?php namespace Dvlpp\Sharp\Validation;
+<?php
+
+namespace Dvlpp\Sharp\Validation;
 
 use Validator;
 use Dvlpp\Sharp\Exceptions\ValidationException;

diff --git a/src/helpers/sharp_internal.php b/src/helpers/sharp_internal.php
@@ -235,4 +235,10 @@ function get_file_path($relativePath, $disk='local')
     $storagePath  = Storage::disk($disk)->getDriver()->getAdapter()->getPathPrefix();
 
     return $storagePath . $relativePath;
+}
+
+function key_name_for_form_field($key)
+{
+    $key = str_replace("~", "-", $key);
+    return "sf-$key";
 }