Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-dom dependency on React Native #686

Merged
merged 1 commit into from
Mar 21, 2017
Merged

remove react-dom dependency on React Native #686

merged 1 commit into from
Mar 21, 2017

Conversation

nihgwu
Copy link
Member

@nihgwu nihgwu commented Mar 7, 2017

No description provided.

@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Changes Unknown when pulling 0ab3e54 on nihgwu:master into ** on dvajs:master**.

@@ -103,6 +102,9 @@
"react": "global:React",
"react-dom": "global:ReactDOM"
},
"react-native" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥加这段?给个来源链接吧

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry,忘记看讨论区了。忽略我

@nihgwu
Copy link
Member Author

nihgwu commented Mar 8, 2017 via email

@sorrycc
Copy link
Member

sorrycc commented Mar 8, 2017

@nihgwu 👍🏾

@nihgwu
Copy link
Member Author

nihgwu commented Mar 8, 2017 via email

@nihgwu
Copy link
Member Author

nihgwu commented Mar 16, 2017

any plan to ship this? @sorrycc

@sorrycc sorrycc merged commit 1d07617 into dvajs:master Mar 21, 2017
@sorrycc
Copy link
Member

sorrycc commented Mar 27, 2017

@nihgwu
Copy link
Member Author

nihgwu commented Mar 27, 2017

npm 上还是 1.2.1

@afc163
Copy link
Contributor

afc163 commented Mar 27, 2017

npm dist-tag ls dva
beta: 1.3.0-beta2
latest: 1.2.1

@nihgwu
Copy link
Member Author

nihgwu commented Mar 27, 2017

@afc163 OK,看到了

还有貌似如果根据 semver 的规则,应该是 1.3.0-beta.2 而不是 1.3.0-beta2 @sorrycc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants