-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove react-dom dependency on React Native #686
Conversation
Changes Unknown when pulling 0ab3e54 on nihgwu:master into ** on dvajs:master**. |
@@ -103,6 +102,9 @@ | |||
"react": "global:React", | |||
"react-dom": "global:ReactDOM" | |||
}, | |||
"react-native" : { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥加这段?给个来源链接吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry,忘记看讨论区了。忽略我
应该是这个以及下面的comments facebook/react-native#2208
如果合并了能发个新版本吗,有代码洁癖😂
用dva开发react native有一段时间了,很棒的框架👍
能把我加到主维护者吗,我想进一步改进在RN中的开发体验,这两天会写一个更加贴近真实项目的demo,还有router相关的部分
On 8 Mar 2017, at 08:22, chencheng (云谦) <[email protected]<mailto:[email protected]>> wrote:
@sorrycc commented on this pull request.
________________________________
In package.json<#686 (comment)>:
@@ -103,6 +102,9 @@
"react": "global:React",
"react-dom": "global:ReactDOM"
},
+ "react-native" : {
为啥加这段?给个来源链接吧
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#686 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACeY8jWIT5cTW9G4FXfXHEC0qX24jqgLks5rjfS3gaJpZM4MVucw>.
|
@nihgwu 👍🏾 |
Thanks
On 8 Mar 2017, at 08:59, chencheng (云谦) <[email protected]<mailto:[email protected]>> wrote:
@nihgwu<https://github.com/nihgwu> 👍🏾
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#686 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACeY8jE2TiLvYBO0XPNVUWpzEKpN47eQks5rjf2HgaJpZM4MVucw>.
|
any plan to ship this? @sorrycc |
npm 上还是 1.2.1 |
|
No description provided.