Fix dl/download-default-config error
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton for contributing, @hartikainen. This is my first decent open-source project so I'm always in awe when people chip in 😀 Do you mind fixing this in the templates, too? Then I'll merge. |
Otherwise `dl/download-default-config` always fails.
hartikainen
force-pushed
the
download-default-config-fix
branch
from
feb72a8 to
54fde26
Compare
|
Fixed 🙂 |
|
Awesome, thanks again @hartikainen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final error message ("Error occurred while downloading...") is currently in the
progn-block, causing thedl/download-default-configfunction to always error. This moves the error outside theprogn-block and should fix the issue.