Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extraConfig blocks for SSH config to use home-manager built in functions #74

Merged
merged 4 commits into from
May 2, 2024

Conversation

sonnius
Copy link
Contributor

@sonnius sonnius commented May 1, 2024

This change uses the home-manager built-in functions to configure ssh_config, it also moves these statements above the 'general' configuration which makes sense for ssh_config as the first match in config is applied.

sonnius and others added 2 commits May 1, 2024 09:03
functions

This change uses the home-manager built-in functions to configure
ssh-config, it also moves these statements above the 'general'
configuration which makes sense for ssh_config as the first match in
config is applied.
@dustinlyons
Copy link
Owner

@sonnius Do you mind also updating this in templates/starter/ and templates/starter-with-secrets?

Thanks for contributing!

sonnius and others added 2 commits May 2, 2024 09:56
The templates needed updating to be in line with the main
configuration changes proposed in this pull request.
@sonnius
Copy link
Contributor Author

sonnius commented May 1, 2024

  • Updated the template files also
  • Restored the original filepath for SSH include
  • Tweaked comment about updating SSH config when using different github key location.

@dustinlyons dustinlyons merged commit 82fc40c into dustinlyons:main May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants