Upgrade rust toolchain #3522
Draft
Upgrade rust toolchain #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-sonuga
force-pushed
the
upgrade-rust-toolchain
branch
from
3186421 to
2bf3d9a
Compare
…anual_inspect` lints
…ter_doc_comments`, `unnecessary_map_or`, `unnecessary_first_then_check` and `useless_conversion` lints
…tr_arg` and `unnecessary_map_or` lints
…continuation`, `ptr_arg`, `unnecessary_map_or`, `needless_lifetimes`, `literal_string_with_formatting_args`, `manual_unwrap_or_default` and dead code lints and remove `lazy_cell` feature flag
…e code to pass `empty_line_after_doc_comments`, `needless_lifetimes` and `manual_div_ceil` lints
…h the new and old toolchain
…rror with rkyv `Serialize` and `Deserialize` derives
d-sonuga
force-pushed
the
upgrade-rust-toolchain
branch
from
2bf3d9a to
00d46db
Compare
d-sonuga
requested review from
HDauven,
herr-seppia,
miloszm and
Neotamandua
and removed request for
HDauven
herr-seppia
reviewed
Feb 21, 2025
| @@ -2,7 +2,7 @@ all: wasm clippy | |||
|
|
|||
| wasm: ## Generate the optimized WASM for the contract given | |||
| @RUSTFLAGS="$(RUSTFLAGS) --remap-path-prefix $(HOME)= -C link-args=-zstack-size=65536" \ | |||
| cargo build \ | |||
| cargo +dusk build \ | |||
There was a problem hiding this comment.
Why did you changed to use dusk compiler?
It should work with standard compiler
There was a problem hiding this comment.
The new toolchain can't compile piecrust-uplink anymore because of changes made to the panic handler in rust 1.81.0.
There was a problem hiding this comment.
So, should we first update piecurst?
There was a problem hiding this comment.
We can.
We don't need to do that right now if all the contracts use the dusk toolchain, but if we do decide to do that, then the dusk toolchain, too, will need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3470