Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusk: serialize genesis events as json on gql #3510

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Neotamandua
Copy link
Member

@Neotamandua Neotamandua commented Feb 18, 2025

This changes the moonlight endpoints to send out event data either hex encoded (unknown events) or as json representation of the structs (for known events from genesis contracts).

@Neotamandua Neotamandua force-pushed the neotamandua/serde_on_genesis_events branch from 79ba2c7 to bc5eb67 Compare February 18, 2025 10:54
@Neotamandua Neotamandua marked this pull request as draft February 18, 2025 10:55
@Neotamandua Neotamandua force-pushed the neotamandua/serde_on_genesis_events branch from bc5eb67 to 8afd17a Compare February 18, 2025 11:40
@Neotamandua Neotamandua marked this pull request as ready for review February 18, 2025 11:53
@Neotamandua Neotamandua force-pushed the neotamandua/serde_on_genesis_events branch from 8afd17a to 2ea9763 Compare February 18, 2025 16:22
herr-seppia
herr-seppia previously approved these changes Feb 20, 2025
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neotamandua Neotamandua force-pushed the neotamandua/serde_on_genesis_events branch from 2ea9763 to 5e8b0a5 Compare February 20, 2025 16:28
- Add dusk-core serde feature
- Remove obsolete structs
- Update CHANGELOG
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neotamandua Neotamandua merged commit 0704645 into master Feb 20, 2025
16 checks passed
@Neotamandua Neotamandua deleted the neotamandua/serde_on_genesis_events branch February 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rusk: serialize bytes to json for archive moonlight endpoints if we know the event
2 participants