Skip to content

Commit

Permalink
Update patch set 4
Browse files Browse the repository at this point in the history
Patch Set 4:

> Patch Set 4:
> 
> Sorry, but this is not the way to do that. Registry key approach was discussed downstream in nodejs, Heath Stewart who is responsible for the VS installer said explicitly that the registry entry is not supported (nodejs/node-gyp#1103 (comment))
> 
> In node-gyp we used Rafael's powershell script that can query VS COM server (nodejs/node-gyp#1130). We used that to find VS and set environment variables. IMHO we should do the same thing here.

Obviously, but I like this solution for this project, it's good enough...
...
...
...
...
...
...
You know what, I'll make another PR with the full script

Patch-set: 4
Reviewer: Gerrit User 1188132 <1188132@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
  • Loading branch information
Gerrit User 1188132 authored and Gerrit Code Review committed Mar 16, 2017
1 parent 3462b53 commit 20b36f9
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 20b36f9

Please sign in to comment.