Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Fix panic on invalid client data #137

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Fix panic on invalid client data #137

merged 6 commits into from
Mar 30, 2022

Conversation

horgh
Copy link
Contributor

@horgh horgh commented Mar 29, 2022

This builds on #122.

@horgh horgh mentioned this pull request Mar 29, 2022
Merged
6543
6543 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and tests passed localy

@6543
Copy link
Contributor

6543 commented Mar 29, 2022

through I have no merge permission - that a other must do ...

james-d-elliott
james-d-elliott approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job forking to keep the original author credited.

@MasterKale MasterKale merged commit 03696f3 into duo-labs:master Mar 30, 2022
@horgh horgh deleted the horgh/panic branch March 30, 2022 14:59
@horgh
Copy link
Contributor Author

horgh commented Mar 30, 2022

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@james-d-elliott james-d-elliott james-d-elliott approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@horgh @6543 @james-d-elliott @MasterKale @zachhuff386