Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete redundant sentence in calldata description #221

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore: delete redundant sentence in calldata description #221

merged 1 commit into from
Mar 28, 2023

Conversation

ardislu
Copy link
Contributor

@ardislu ardislu commented Mar 28, 2023

The calldata paragraph in "About the EVM" currently reads:

The calldata region is the data sent to a transaction as part of a smart contract transaction. For example, when creating a contract, calldata would be the constructor code of the new contract. It is important to note that when a contract executes an xCALL instruction, it also creates an internal transaction, with a resulting calldata region in the new context. Calldata is immutable, and can be read with instructions CALLDATALOAD, CALLDATASIZE, and CALLDATACOPY. When a contract executes an xCALL instruction, it also creates an internal transaction. As a result, when executing xCALL, there is a calldata region in the new context.

(Emphasis mine)

This PR will update the paragraph to delete the redundant sentence, so it will read:

The calldata region is the data sent to a transaction as part of a smart contract transaction. For example, when creating a contract, calldata would be the constructor code of the new contract. Calldata is immutable, and can be read with instructions CALLDATALOAD, CALLDATASIZE, and CALLDATACOPY. It is important to note that when a contract executes an xCALL instruction, it also creates an internal transaction. As a result, when executing xCALL, there is a calldata region in the new context.

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
evm-codes ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 2:47AM (UTC)

Copy link
Member

@peroket peroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@peroket peroket merged commit a174624 into duneanalytics:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants