Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Avoid assert False as those are removed by CPython's -O flag #56

Merged
merged 1 commit into from
Jun 20, 2019
Merged

cli: Avoid assert False as those are removed by CPython's -O flag #56

merged 1 commit into from
Jun 20, 2019

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Jun 20, 2019

Issue caught by flake8-bugbear in the lint CI task.

@nbraud nbraud mentioned this pull request Jun 20, 2019
Merged
3 tasks
@duckinator
Copy link
Owner

thanks! ❤️

bors r+

bors bot added a commit that referenced this pull request Jun 20, 2019
@bors @nbraud
Merge #56
4b17f4b 
56: cli: Avoid `assert False` as those are removed by CPython's -O flag r=duckinator a=nbraud

Issue caught by flake8-bugbear in the `lint` CI task.

Co-authored-by: Nicolas Braud-Santoni <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 20, 2019

Build succeeded

  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • Lint
  • Linux container:python:3.5-slim
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors bors bot merged commit 126cc3a into duckinator:master Jun 20, 2019
@nbraud nbraud deleted the lint-error branch June 22, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @duckinator