Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delayed tracker test cases #63

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add delayed tracker test cases #63

merged 1 commit into from
Oct 22, 2021

Conversation

jonathanKingston
Copy link
Collaborator

I added two cases (where we're using script to inject trackers) to delay loading of the tracker if the ?delay=1000 etc param is passed.

This allows us to verify if the reporting in mobile updates when the tracker is blocked etc. I notice we don't do the animation but clicking on the chip displays the number as and when the blocking happens.

Test case for: https://app.asana.com/0/414235014887631/1201210452027324/f

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments.

package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
tracker-reporting/document-fragment.html Show resolved Hide resolved
tracker-reporting/utils.js Outdated Show resolved Hide resolved
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kdzwinel kdzwinel merged commit 33ee5f0 into main Oct 22, 2021
@kdzwinel kdzwinel deleted the jkt/delayed-trackers branch October 22, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants