Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the home page to preserve the scheme of the original URL. #705

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Update the home page to preserve the scheme of the original URL. #705

merged 5 commits into from
Sep 2, 2022

Conversation

samsymons
Copy link
Collaborator

@samsymons samsymons commented Aug 30, 2022 •
edited by tomasstrba
Loading

Task/Issue URL: https://app.asana.com/0/1199230911884351/1202894007986850/f
Tech Design URL:
CC:

Description:

This PR updates the new tab page to remember the scheme that was used to open URLs from history.

Steps to test this PR:

  1. Trigger the Fire button to clear your history out
  2. Visit the HTTP variant of the privacy test pages: http://privacy-test-pages.glitch.me/, click one of the links in the list to open another test page
  3. Open the new tab page and click the privacy test pages link at the top of the recently visited list, verify that it opens in HTTP (not HTTPS). Check that the path that you visited also opens in HTTP.
  4. Trigger the Fire button again
  5. Visit the HTTPS privacy test pages: https://privacy-test-pages.glitch.me/, click on one of the links again
  6. Open the new tab page once more and check that the privacy test pages links open with HTTPS

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba self-assigned this Aug 31, 2022
tomasstrba
tomasstrba approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Works as expected! 👏

DuckDuckGo/Home Page/Model/HomePageRecentlyVisitedModel.swift Outdated Show resolved Hide resolved
@tomasstrba tomasstrba assigned samsymons and unassigned tomasstrba Sep 1, 2022
@samsymons samsymons requested a review from tomasstrba September 1, 2022 23:53
@samsymons samsymons assigned tomasstrba and unassigned samsymons Sep 1, 2022
tomasstrba
tomasstrba approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Even better 🥇

@tomasstrba tomasstrba assigned samsymons and unassigned tomasstrba Sep 2, 2022
@samsymons
Merge branch 'develop' into sam/preserve-scheme-when-opening-tabs-fro…
75c32a3 
…m-recently-visited

* develop:
  Brad/referrer trimming (#682)
  Update BrowserServicesKit for iOS Remote Messaging support (#709)
  Update BSK with fix (#704)
  Add test for embedded config file (#703)
@samsymons
Fix the Autoconsent path.
8666f6e
@samsymons
Merge branch 'develop' into sam/preserve-scheme-when-opening-tabs-fro…
0099592 
…m-recently-visited

# Via GitHub
* develop:
  Add the bookmarks submenu to the browser's More menu (#684)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@samsymons samsymons merged commit 3383c81 into develop Sep 2, 2022
@samsymons samsymons deleted the sam/preserve-scheme-when-opening-tabs-from-recently-visited branch September 2, 2022 14:18
samsymons added a commit that referenced this pull request Sep 20, 2022
@samsymons
Merge branch 'develop' into sam/bookmarks-phase-2-favicon-import
24de70c 
* develop:
  Bump version to 0.28.9 and update embedded files
  BSK update for changed URL parameter API (#715)
  Improvements in CPM coverage (#707)
  Fix a couple calculations used for the bookmarks bar. (#713)
  Set version to 0.28.8
  Remove invalidate back item (#711)
  Set version to 0.28.7.
  Update the home page to preserve the scheme of the original URL. (#705)
  Add the bookmarks submenu to the browser's More menu (#684)
  Brad/referrer trimming (#682)
  Update BrowserServicesKit for iOS Remote Messaging support (#709)
samsymons added a commit that referenced this pull request Sep 20, 2022
@samsymons
Merge branch 'develop' into sam/bookmarks-phase-2-pinning
2e15a19 
# By Sam Symons (4) and others
# Via Dominik Kapusta
* develop:
  Bump version to 0.28.9 and update embedded files
  BSK update for changed URL parameter API (#715)
  Improvements in CPM coverage (#707)
  Fix a couple calculations used for the bookmarks bar. (#713)
  Set version to 0.28.8
  Remove invalidate back item (#711)
  Set version to 0.28.7.
  Update the home page to preserve the scheme of the original URL. (#705)
  Add the bookmarks submenu to the browser's More menu (#684)
  Brad/referrer trimming (#682)
  Update BrowserServicesKit for iOS Remote Messaging support (#709)
  Update BSK with fix (#704)
  Add test for embedded config file (#703)
  add config file (#702)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/Common/Localizables/UserText.swift
samsymons added a commit that referenced this pull request Sep 20, 2022
@samsymons
Merge branch 'develop' into sam/bookmarks-phase-2-manual-reordering-u…
2068f21 
…pdated

# By Sam Symons (16) and others
# Via Chris Brind (3) and others
* develop: (38 commits)
  Bump version to 0.28.9 and update embedded files
  BSK update for changed URL parameter API (#715)
  Improvements in CPM coverage (#707)
  Fix a couple calculations used for the bookmarks bar. (#713)
  Set version to 0.28.8
  Remove invalidate back item (#711)
  Set version to 0.28.7.
  Update the home page to preserve the scheme of the original URL. (#705)
  Add the bookmarks submenu to the browser's More menu (#684)
  Brad/referrer trimming (#682)
  Update BrowserServicesKit for iOS Remote Messaging support (#709)
  Update BSK with fix (#704)
  Add test for embedded config file (#703)
  add config file (#702)
  Improve bookmark UI context menus (#678)
  Force callers to refresh even when the save fails. (#701)
  update version
  Update BSK (#693)
  update embedded files
  Possible fix for errant pop-up (#694)
  ...

# Conflicts:
#	DuckDuckGo/Bookmarks/Services/ContextualMenu.swift
#	DuckDuckGo/Common/Localizables/UserText.swift
samsymons added a commit that referenced this pull request Oct 19, 2022
@samsymons
Update the home page to preserve the scheme of the original URL. (#705)
9d7730e 
Task/Issue URL: https://app.asana.com/0/1199230911884351/1202894007986850/f
Tech Design URL:
CC:

Description:

This PR updates the new tab page to remember the scheme that was used to open URLs from history.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @tomasstrba