Update for BSK changes of URL parameter API #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 26, 2022
# By Sam Symons (3) and others # Via Chris Brind (3) and GitHub (1) * develop: Improve bookmark UI context menus (#678) Force callers to refresh even when the save fails. (#701) update version Update BSK (#693) update embedded files Possible fix for errant pop-up (#694) Use LazyVStack to improve new tab page performance. (#699) Update to use URL constructors and helpers from BSK (#698) Update for BSK changes of URL parameter API (#697) # Conflicts: # DuckDuckGo/Common/Localizables/UserText.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202861312006266/f
Tech Design URL:
CC:
Description:
This PR updates usage of BSK's URL parameter API.
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM