Allow cmd+1..9 to select pinned tabs #656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202659052151493/f
Description:
Add TabIndex API that "converts" an integer index into TabIndex for a given TabCollectionViewModel.
Make showTab main menu action aware of pinned tabs, and use this API to select correct tab.
This patch also adds extra assertions to
TabIndex.first(in:)
andTabIndex.last(in:)
andfixes
TabIndex.next(in:)
when there are only pinned tabs.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM