Update the Fireproof checkmark in the Save Credentials view controller #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
reviewed
Apr 26, 2022
Bunn
approved these changes
Apr 26, 2022
samsymons
commented
Apr 26, 2022
Comment on lines
-511
to
-513
| var legacyStore = LocalStatisticsStore.LegacyStatisticsStore() | ||
| legacyStore.atb = "fake-atb-value" | ||
| legacyStore.installDate = Date() |
There was a problem hiding this comment.
Also I added this for the lock screen ages ago, but it was mostly a way to test the upgrade flow during PR review - that is long since resolved and never needs testing again, so I've removed it.
samsymons
added a commit
that referenced
this pull request
Apr 27, 2022
# By Alexey Martemyanov (3) and others # Via GitHub * develop: Lazy load background tabs at app startup (#553) Update the Fireproof checkmark in the Save Credentials view controller (#555) Support config v2 (#528) Fullscreen video fixing (#541) Add data import failure pixels (#552) Update BSK to fix autofill on Catalina (#551) fix contrast bug on Catalina / Big Sur (#546) Disable download reload on page tab reactivation/session restoration (#516) Add "New Window" item to App Dock menu (#544) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
3 tasks
samsymons
added a commit
that referenced
this pull request
Apr 29, 2022
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202118895326543/f Tech Design URL: CC: Description: This PR adds an additional check that was missed in #555. I've re-used the same Asana task as a reference, since this is directly a part of those changes, which themselves have not yet shipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202118895326543/f
Tech Design URL:
CC:
Description:
This PR updates the Save Credentials VC to accurately reflect whether a domain is already fireproof, and to change that in the database if the checkmark changes. That is, if a domain is already fireproof and you un-check that box before saving credentials, it will now remove it from the Fireproof store.
This PR has also taken a pass over the debug menu, moving all of the "Reset *" options into their own "Reset Data" submenu, and adding a new "UI Triggers" submenu for triggering pieces of the UI which can be annoying to iterate on if you need to run through a bunch of steps on a website. There's only one option in this menu for now, which is to trigger the Save Credentials VC.
Note: I went back and forth on a full refactor of this popover, but have since been given another task which requires making larger changes to this UI, so I've decided to just open this PR now with the simplest changes possible in order to get this fixed.
Steps to test this PR:
example.comin Autofill, and thatexample.comis not Fireproofexample.comin Autofill and it should be FireproofTesting checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM