Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI glitches in popovers on Catalina #537

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Apr 13, 2022

Task/Issue URL: https://app.asana.com/0/1177771139624306/1202121324275642/f

Description:
On Catalina, override popovers' top-level views appearance so that the vibrancy effect is removed,
and then subscribe to app appearance updates to keep them in sync with the rest of the app.

Steps to test this PR:

  1. Run the app on Catalina. You can use the review build attached to Asana task.
  2. If you're still with me, trigger the following popovers and verify that they don't contain transparent areas around labels and buttons:
    1. Autofill
    2. Save Identity/Credentials/Payment Method
    3. Bookmarks
    4. Add bookmark (from address bar)
  3. If you like, you can also do this:
    1. SSH to Catalina
    2. While keeping the popover open, trigger the following command to switch between dark and light mode, and verify that the popover UI is correctly updated to the new appearance:
$ osascript -e 'tell app "System Events" to tell appearance preferences to set dark mode to not dark mode'

(you can't do it from the UI on Catalina machine because popover would disappear when losing focus).

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@mallexxx mallexxx self-assigned this Apr 15, 2022
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
(I assume non-working on-page autofill is a known issue and out of scope for this PR)

@mallexxx mallexxx assigned ayoy and unassigned mallexxx Apr 15, 2022
@ayoy ayoy merged commit 712fc86 into develop Apr 16, 2022
@ayoy ayoy deleted the dominik/catalina-popovers branch April 16, 2022 09:41
samsymons added a commit that referenced this pull request Apr 20, 2022
# By Alexey Martemyanov (1) and others
# Via GitHub
* develop:
  fix auto consent again (#535)
  don't draw webview background to avoid flashes (#545)
  fix Copy from Address Bar (#543)
  Fix UI glitches in popovers on Catalina (#537)
  Add new address bar context menu options (#542)
  Support top frame focus for autofill (#465)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants