Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard #533

Merged
merged 2 commits into from
May 5, 2022
Merged

Update dashboard #533

merged 2 commits into from
May 5, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1199230911884351/1202087676332886/f
Tech Design URL:
CC: @GuiltyDolphin @alistairjcbrown @tomasstrba

Description:
This PR updates the privacy dashboard to make selecting a breakage category optional.

Steps to test this PR:

  1. Go through the breakage flow in the privacy dashboard
  2. Submit button should be enabled without entering any data or selecting a category

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy assigned brindy and Bunn and unassigned brindy Apr 19, 2022
Bunn
Bunn approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
Before the PR the submit button was grayed out, this change makes it available without selection a category.

@Bunn Bunn assigned SlayterDev and unassigned Bunn Apr 26, 2022
@SlayterDev SlayterDev merged commit e0248a0 into develop May 5, 2022
@SlayterDev SlayterDev deleted the brad/dashboard-breakage branch May 5, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SlayterDev @Bunn @brindy