Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra space on popup windows #522

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Remove extra space on popup windows #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions DuckDuckGo/Main/View/Main.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</connections>
</containerView>
<customView translatesAutoresizingMaskIntoConstraints="NO" id="af1-Eb-VaG" userLabel="Separator" customClass="ColorView" customModule="DuckDuckGo_Privacy_Browser" customModuleProvider="target">
<rect key="frame" x="0.0" y="702" width="1024" height="1"/>
<rect key="frame" x="0.0" y="708" width="1024" height="1"/>
<constraints>
<constraint firstAttribute="height" constant="1" id="hrt-pu-NuL"/>
</constraints>
Expand All @@ -46,16 +46,16 @@
</userDefinedRuntimeAttributes>
</customView>
<containerView translatesAutoresizingMaskIntoConstraints="NO" id="wFH-xq-50o">
<rect key="frame" x="0.0" y="703" width="1024" height="48"/>
<rect key="frame" x="0.0" y="709" width="1024" height="42"/>
<constraints>
<constraint firstAttribute="height" constant="48" id="vZS-tl-wOP"/>
<constraint firstAttribute="height" constant="42" id="vZS-tl-wOP"/>
</constraints>
<connections>
<segue destination="R9l-dg-lKa" kind="embed" destinationCreationSelector="createNavigationBarViewControllerWithCoder:sender:segueIdentifier:" id="Br9-o3-sQ8"/>
</connections>
</containerView>
<containerView hidden="YES" translatesAutoresizingMaskIntoConstraints="NO" id="Jbn-9T-FNt" userLabel="Find in Page Container View">
<rect key="frame" x="312" y="667" width="400" height="40"/>
<rect key="frame" x="312" y="673" width="400" height="40"/>
<constraints>
<constraint firstAttribute="height" constant="40" id="Hzq-Qn-wpU"/>
<constraint firstAttribute="width" constant="400" id="Ndt-bt-exS"/>
Expand Down Expand Up @@ -101,6 +101,7 @@
<outlet property="navigationBarTopConstraint" destination="TRm-AX-VcL" id="cCS-Fd-hJd"/>
<outlet property="tabBarContainerView" destination="lYg-bX-QrJ" id="nor-E0-cFP"/>
<outlet property="webContainerView" destination="SYo-8W-jl3" id="DoZ-Ih-dHA"/>
<outlet property="webViewTopConstraint" destination="js0-Db-kRi" id="puD-Cr-Val"/>
</connections>
</viewController>
<customObject id="rPt-NT-nkU" userLabel="First Responder" customClass="NSResponder" sceneMemberID="firstResponder"/>
Expand Down
2 changes: 2 additions & 0 deletions DuckDuckGo/Main/View/MainViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ final class MainViewController: NSViewController {
@IBOutlet weak var findInPageContainerView: NSView!
@IBOutlet var navigationBarTopConstraint: NSLayoutConstraint!
@IBOutlet var addressBarHeightConstraint: NSLayoutConstraint!
@IBOutlet var webViewTopConstraint: NSLayoutConstraint!

@IBOutlet var divider: NSView!

Expand Down Expand Up @@ -72,6 +73,7 @@ final class MainViewController: NSViewController {
tabBarViewController.view.isHidden = true
tabBarContainerView.isHidden = true
navigationBarTopConstraint.constant = 0.0
webViewTopConstraint.constant = navigationBarViewController.view.frame.height
addressBarHeightConstraint.constant = tabBarContainerView.frame.height
} else {
navigationBarContainerView.wantsLayer = true
Expand Down