Fix LoginsPreferences instances being out of sync #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The model is an adapter for displaying values in Autofill Preferences pane.
samsymons
requested changes
Apr 4, 2022
There was a problem hiding this comment.
This is looking great, nice work! 👏 I really like this approach to the problem.
There's one last thing we need to restore that was lost during the preferences re-write: changing the Auto-Lock setting needs to be gated behind an authentication check, otherwise someone could disable the check in order to bypass it.
The check was originally located here - once we have that authentication back in, this is good to merge!
ayoy
commented
Apr 4, 2022
| @@ -20,42 +20,84 @@ import Foundation | |||
|
|
|||
| final class AutofillPreferencesModel: ObservableObject { | |||
|
|
|||
| @Published var isAutoLockEnabled: Bool { | |||
| @Published var askToSaveUsernamesAndPasswords: Bool { | |||
There was a problem hiding this comment.
Lots of git diff noise here, but I only updated isAutoLockEnabled and autoLockThreshold and then I moved them below the other 3 properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1202064896664660/f
Tech Design URL:
CC: @samsymons
Description:
I restored Core-Data-backed
LoginsPreferencesand addedLoginsPreferencesModelwith@Publishedproperties only to be used by the preferences screen.While updating it, I decided to rename
LoginsPreferencesand related symbols toAutofill*.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM