Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for default browser during onboarding #391

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 6, 2022

Task/Issue URL: https://app.asana.com/0/392891325557410/1201554073062083
Tech Design URL:
CC:

Description:

Ensure that user can progress if they hit set as default and browser is (somehow) already default

Steps to test this PR:

  1. Comment out the following lines in DefaultBrowserPreferences.swift:
        #if DEBUG
        bundleID = bundleID.drop(suffix: ".debug")
        #endif
  1. With a window open from the Debug menu reset the Mac Waitlist Lock Screen
  2. Open a new window and go through the flow. At "set default" click the set as default button and set the browser as default using the system popup
  3. Finish the flow and repeat from step 1
  4. The second time through clicking the set as default button should just progress to the next screen

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link

@bstandaert-ddg bstandaert-ddg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@bstandaert-ddg bstandaert-ddg merged commit b653c1b into develop Jan 6, 2022
@bstandaert-ddg bstandaert-ddg deleted the brindy/onboarding-set-default-fix branch January 6, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants