Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content scope code sharing #389

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Jan 5, 2022

Task/Issue URL: https://app.asana.com/0/0/1201621593347477/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Load up the page and check for navigator.globalPrivacyControl in the DOM
  2. Change the toggle and check for 'false' value.

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@jonathanKingston jonathanKingston mentioned this pull request Jan 5, 2022
1 task
@jonathanKingston jonathanKingston requested review from bwaresiak and brindy and removed request for bwaresiak and brindy January 5, 2022 20:39
@jonathanKingston jonathanKingston mentioned this pull request Jan 5, 2022
1 task
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

DuckDuckGo/BrowserTab/Model/UserScripts.swift Outdated Show resolved Hide resolved
DuckDuckGo/ContentBlocker/ScriptSourceProviding.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonathanKingston jonathanKingston merged commit 0599ad1 into develop Jan 7, 2022
@jonathanKingston jonathanKingston deleted the jkt/content-scope branch January 7, 2022 17:46
muodov added a commit that referenced this pull request Mar 17, 2024
Task/Issue URL:
https://app.asana.com/0/1206853951101015/1206853951101015
Autoconsent Release:
https://github.com/duckduckgo/autoconsent/releases/tag/v10.3.0


## Description
Updates Autoconsent to version
[v10.3.0](https://github.com/duckduckgo/autoconsent/releases/tag/v10.3.0).

### Autoconsent v10.3.0 release notes
#### 🚀 Enhancement

- DDG release automation
[#389](duckduckgo/autoconsent#389)
([@muodov](https://github.com/muodov))
- Bump the dev-dependencies group with 4 updates
[#390](duckduckgo/autoconsent#390)
([@dependabot[bot]](https://github.com/dependabot[bot]))

#### 🐛 Bug Fix

- Fix infinite reload for OneTrust sites
[#393](duckduckgo/autoconsent#393)
([@muodov](https://github.com/muodov))
- Script to crawl page text content in multiple languages.
[#386](duckduckgo/autoconsent#386)
([@sammacbeth](https://github.com/sammacbeth))
- Update Asana sync action
[#388](duckduckgo/autoconsent#388)
([@sammacbeth](https://github.com/sammacbeth))

#### Authors: 3

- [@dependabot[bot]](https://github.com/dependabot[bot])
- Maxim Tsoy ([@muodov](https://github.com/muodov))
- Sam Macbeth ([@sammacbeth](https://github.com/sammacbeth))


## Steps to test
This release has been tested during Autoconsent development. You can
check the release notes for more information.

Co-authored-by: muodov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants