Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix override removal #3828

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Feb 4, 2025

Task/Issue URL: https://app.asana.com/0/1204186595873227/1209321233961841

Description: Fix a bug where the feature flag override “remove override” submenu does not appear

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Go the Debug Feature Flags menu
  2. Try and override a feature
  3. check you can remove the override

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SabrinaTardio SabrinaTardio changed the base branch from main to release/1.125.0 February 4, 2025 19:19
@SabrinaTardio SabrinaTardio requested a review from ayoy February 4, 2025 19:25
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SabrinaTardio SabrinaTardio merged commit 107fb07 into release/1.125.0 Feb 5, 2025
33 of 37 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/fix-override-menu branch February 5, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants