Universal auth v1 and v2 NetworkProtection #3817
Merged
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Feb 4, 2025
# Conflicts: # DuckDuckGo-macOS.xcodeproj/project.pbxproj # DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 4, 2025
Task/Issue URL: https://app.asana.com/0/72649045549333/1209279739041319/f iOS PR: duckduckgo/iOS#3914 macOS PR: duckduckgo/macos-browser#3817 What kind of version bump will this require?: Major **Description**: This PR introduces a few changes and some unused code in Network Protection allowing the future adoption of Auth V2. All code related to Auth V2 is not used; instead, Auth V1 is maintained.
federicocappelli
deleted the
fcappelli/authv2/network_protection_2tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209279739041319/f
Description:
This PR introduces a few changes and some unused code in network protection allowing the future adoption of Auth V2.
All code related to Auth V2 is not used and instead, Auth V1 is maintained.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation