Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix session restoration ui test #3753

Merged

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1202406491309510/1209193663115526/f

Description:

  • fix failing test due to session state data not getting to record due to force termination

Steps to test this PR:

  1. Validate test_tabStateAtRelaunch_shouldContainTwoSitesVisitedInPreviousSession_whenReopenAllWindowsFromLastSessionIsSet passes

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez merged commit a64c14c into release/1.123.0 Jan 21, 2025
30 checks passed
@diegoreymendez diegoreymendez deleted the alex/fix-failing-session-restoration-ui-test branch January 21, 2025 14:12
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants