BSK Bump - Defaults internal Privacy Pro links to /subscriptions #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, default Privacy Pro links were sent to `/subscriptions/welcome`, and the frontend redirected to `/subscriptions`. Currently, this will still result in a redirect to `/subscriptions/welcome` for subscribed users—effectively a no-op. After an upcoming frontend release, this will show `/subscriptions` with a link to `/subscriptions/welcome`.
aataraxiaa
force-pushed
the
pete/pp-remove-welcome-path
branch
from
a997a1d to
752fab6
Compare
miasma13
approved these changes
Jan 16, 2025
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 16, 2025
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209009315184468/f iOS PR: duckduckgo/iOS#3812 macOS PR: duckduckgo/macos-browser#3741 What kind of version bump will this require?: Patch **Description**: Previously, default Privacy Pro links were sent to `/subscriptions/welcome`, and the frontend redirected to `/subscriptions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209009315184468/f
Description:
Previously, default Privacy Pro links were sent to
/subscriptions/welcome, and the frontend redirected to/subscriptions.Currently, this will still result in a redirect to
/subscriptions/welcomefor subscribed users—effectively a no-op. After an upcoming frontend release, this will show/subscriptionswith a link to/subscriptions/welcome.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template