Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Duckplayer handler URL #3730

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix Duckplayer handler URL #3730

merged 1 commit into from
Jan 15, 2025

Conversation

afterxleep
Copy link
Contributor

@afterxleep afterxleep commented Jan 14, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1204099484721401/1209111326156032/f
Tech Design URL:
CC:

Description:

  • Fixes issue causing DuckPlayer to render the same (incorrect) video

Steps to test this PR:

  1. Go to Settings > DuckPlayer, Check “Always open videos in DuckPlayer"
  2. Go to Settings > DuckPlayer, UNCheck “Open DuckPlayer videos in a new tab whenever possible”
  3. Go to https://www.youtube.com/@mkbhd
  4. Click on a video
  5. Confirm it opens in Duck Player
  6. Hit ‘back'
  7. Click another video
  8. Confirm it opens in Duck Player (Previously, the old video was opening)
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@afterxleep afterxleep requested a review from mallexxx January 14, 2025 19:17
mallexxx
mallexxx approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🏅

@afterxleep afterxleep merged commit 2838619 into main Jan 15, 2025
31 checks passed
@afterxleep afterxleep deleted the daniel/fix.dupe.videos branch January 15, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallexxx mallexxx mallexxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @mallexxx