Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission usage description strings in Info.plist #3518

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Update permission usage description strings in Info.plist #3518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
737b8c1
Update permission usage descriptions in Info.plist
ayoy Nov 5, 2024
dbc506a
Set version to 299
ayoy Nov 5, 2024
84a7a4d
Update all permission usage descriptions
ayoy Nov 5, 2024
c430615
Update description strings
ayoy Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/BuildNumber.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CURRENT_PROJECT_VERSION = 296
CURRENT_PROJECT_VERSION = 299
14 changes: 6 additions & 8 deletions DuckDuckGo/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,21 +521,19 @@
<true/>
</dict>
<key>NSCameraUsageDescription</key>
<string>Allows you to upload photographs and videos</string>
<string>Lets websites ask permission to use your camera for video calls, recording and uploading videos, or taking and uploading photos.</string>
<key>NSHumanReadableCopyright</key>
<string>Copyright © 2024 DuckDuckGo. All rights reserved.</string>
<key>NSLocationUsageDescription</key>
<string>Allows you to share your geolocation</string>
<key>NSLocationWhenInUseUsageDescription</key>
<string>Allows you to share your location</string>
Comment on lines -529 to -530
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not in use at all on macOS (we got a note about this from App Review team too).

<string>Lets websites ask permission to use your location to improve search results, provide weather and directions, or show nearby map locations.</string>
<key>NSMicrophoneUsageDescription</key>
<string>Allows you to share recordings</string>
<string>Lets websites ask permission to use your microphone for audio and video calls or for recording and uploading audio.</string>
<key>NSDownloadsFolderUsageDescription</key>
<string>Allows you to save downloaded files to this folder.</string>
<string>Lets you save files to the Downloads folder on your computer.</string>
<key>NSDesktopFolderUsageDescription</key>
<string>Allows you to save downloaded files to this folder.</string>
<string>Lets you save files to the Desktop folder on your computer.</string>
<key>NSDocumentsFolderUsageDescription</key>
<string>Allows you to save downloaded files to this folder.</string>
<string>Lets you save files to the Documents folder on your computer.</string>
<key>NSPrincipalClass</key>
<string>$(INFOPLIST_KEY_NSPrincipalClass)</string>
<key>NSSupportsAutomaticTermination</key>
Expand Down
Loading