Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding of tab previews for pinned tabs fixed #3513

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1148564399326804/1208347387296425/f

Description:
Stuck tab preview fixed

Steps to test this PR:

  1. Open a new window with bunch of tabs
  2. Pin one tab
  3. Hover mouse cursor over the pinned tab until the preview is shown and don't move with your mouse cursor
  4. Use keyboard to switch to another app (CMD + TAB)
  5. Move the mouse cursor to other position on the screen
  6. Use keyboard to switch back to the DuckDuckGo app
  7. Verify the preview is hidden

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@tomasstrba tomasstrba merged commit 09bfe14 into release/1.113.0 Nov 5, 2024
25 of 26 checks passed
@tomasstrba tomasstrba deleted the tom/preview-fix branch November 5, 2024 16:57
samsymons added a commit that referenced this pull request Nov 6, 2024
# By Dominik Kapusta (4) and others
# Via Dominik Kapusta (1) and others
* main:
  Update Ruby to 3.3.4 (#3519)
  Fix UI tests failing  (#3517)
  Add menu option to set as default browser (#3508)
  Bump version to 1.113.0 (300)
  Deprecate PixelKit daily pixel suffixes (#3509)
  Update permission usage description strings in Info.plist (#3518)
  Fix add to favorites and open in new tabs action not working on manager (#3467)
  Hiding of tab previews for pinned tabs fixed (#3513)
  Update C-S-S to 6.29.0 (#3515)
  Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501)
  Send pixel on sync secure storage read failure (#3497)
  Remove com.apple.security.device.usb entitlement (#3495)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 6, 2024
# By Dominik Kapusta (4) and others
# Via Dominik Kapusta (1) and others
* main:
  VPN clean-up (#3474)
  Update Ruby to 3.3.4 (#3519)
  Fix UI tests failing  (#3517)
  Add menu option to set as default browser (#3508)
  Bump version to 1.113.0 (300)
  Deprecate PixelKit daily pixel suffixes (#3509)
  Update permission usage description strings in Info.plist (#3518)
  Fix add to favorites and open in new tabs action not working on manager (#3467)
  Hiding of tab previews for pinned tabs fixed (#3513)
  Update C-S-S to 6.29.0 (#3515)
  Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501)
  Send pixel on sync secure storage read failure (#3497)
  Remove com.apple.security.device.usb entitlement (#3495)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 7, 2024
# By Dominik Kapusta (4) and others
# Via Dominik Kapusta (1) and others
* main:
  Remove VPN test rollout pixel (#3510)
  VPN clean-up (#3474)
  Update Ruby to 3.3.4 (#3519)
  Fix UI tests failing  (#3517)
  Add menu option to set as default browser (#3508)
  Bump version to 1.113.0 (300)
  Deprecate PixelKit daily pixel suffixes (#3509)
  Update permission usage description strings in Info.plist (#3518)
  Fix add to favorites and open in new tabs action not working on manager (#3467)
  Hiding of tab previews for pinned tabs fixed (#3513)
  Update C-S-S to 6.29.0 (#3515)
  Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501)
  Send pixel on sync secure storage read failure (#3497)
  Remove com.apple.security.device.usb entitlement (#3495)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants