onboarding dax dialogs #3149
Merged
onboarding dax dialogs #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| @@ -32,8 +32,8 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/duckduckgo/BrowserServicesKit", | |||
| "state" : { | |||
| "revision" : "1354d1aec247fd569c69744bb2722f24e16f0bfb", | |||
| "version" : "185.0.1" | |||
| "branch" : "alesab/onboarding", | |||
There was a problem hiding this comment.
Just a reminder to update this
DuckDuckGo/Onboarding/ContextualOnboarding/ContextualOnboardingDialogs.swift
Outdated
Show resolved
Hide resolved
alessandroboron
approved these changes
Aug 28, 2024
SabrinaTardio
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 28, 2024
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208077416568671/f iOS PR: duckduckgo/iOS#3282 macOS PR: duckduckgo/macos-browser#3149 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/481882893211075/1208094950223874/f **Description**: Extracts code from the onboarding that can be used by macOS as well
|
samsymons
added a commit
that referenced
this pull request
Aug 28, 2024
…iption * main: Add error pixels for Subscription keychain access errors (#3147) onboarding dax dialogs (#3149) Logging refactoring phase #2 (#3154) Move WireGuard dependency to VPN extensions (#3144) Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml
samsymons
added a commit
that referenced
this pull request
Aug 29, 2024
# By Dax the Duck (9) and others # Via GitHub (6) and Dominik Kapusta (2) * main: (44 commits) Allow using a production subscription with staging VPN environment (#3109) Add error pixels for Subscription keychain access errors (#3147) onboarding dax dialogs (#3149) Logging refactoring phase #2 (#3154) Move WireGuard dependency to VPN extensions (#3144) Unified feedback form for Privacy Pro (#3058) Fix state restoration after app termination (#3127) Bump Submodules/privacy-reference-tests from `afb4f61` to `6133e7d` (#3148) Bump version to 1.104.0 (250) Set marketing version to 1.104.0 Update embedded files Freemium PIR - Add Desktop RMF Attribute (#3146) Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Add missing secrets to publish_dmg_release.yml Migrate asana-extract-task-id GHA action to a fastlane plugin (#3145) Fix address bar queries when doing math expressions (#3130) Bump version to 1.103.0 (249) Bump version to 1.103.0 (248) Resolving automatic update edge cases (#3142) PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208077416568671/f
Tech Design URL: Look at BSK branch
Description:
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation