Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIPAgent entitlement #2821

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented May 30, 2024

Task/Issue URL: https://app.asana.com/0/0/1207443801635705/f

Description:
Add PIP entitlement to the sandbox app

Steps to test this PR:

  1. Test if PiP works on both Sparkle and App Store builds
  2. Go to https://developer.mozilla.org/en-US/docs/Web/API/Picture-in-Picture_API#examples
  3. Scroll down to examples, and click the PiP button

@Bunn Bunn requested a review from diegoreymendez May 30, 2024 10:01
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 30, 2024
@Bunn Bunn removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 30, 2024
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Nicely done.

@Bunn Bunn merged commit 1bd688c into release/1.90.0 May 30, 2024
26 of 28 checks passed
@Bunn Bunn deleted the bunn/duckplayer/pip-entitlement branch May 30, 2024 10:29
Bunn added a commit that referenced this pull request May 31, 2024
Bunn added a commit that referenced this pull request May 31, 2024
Task/Issue URL:
https://app.asana.com/0/1199230911884351/1207452214141537/f
Tech Design URL:
CC:

**Description**:
This reverts commit 1bd688c.
samsymons added a commit that referenced this pull request May 31, 2024
* main:
  Bump version to 1.90.0 (196)
  Revert "Add PIPAgent entitlement (#2821)" (#2823)
  Bump version to 1.90.0 (195)
  Bump version to 1.90.0 (194)
  Add PIPAgent entitlement (#2821)
  Fixes some VPN uninstallation issues (#2820)
  Bump version to 1.90.0 (193)
  Remove autofill survey (#2819)
  Remove autofill survey (#2819)
  Bump version to 1.90.0 (192)
  Set marketing version to 1.90.0
  Update embedded files
  Privacy Pro survey support (#2816)
samsymons added a commit that referenced this pull request Jun 1, 2024
# By Elle Sullivan (10) and others
# Via GitHub (6) and others
* main: (42 commits)
  Update autoconsent to v10.9.0 (#2822)
  Bump version to 1.90.0 (196)
  Revert "Add PIPAgent entitlement (#2821)" (#2823)
  Bump version to 1.90.0 (195)
  Bump version to 1.90.0 (194)
  Add PIPAgent entitlement (#2821)
  Fixes some VPN uninstallation issues (#2820)
  Bump version to 1.90.0 (193)
  Remove autofill survey (#2819)
  Remove autofill survey (#2819)
  Bump version to 1.90.0 (192)
  Set marketing version to 1.90.0
  Update embedded files
  Privacy Pro survey support (#2816)
  Update PeopleWhiz Broker Files to use hash id (#2814)
  Update BSK due to iOS changes. (#2776)
  Scroll address bar to caret when using arrows (#2799)
  Privacy Pro macOS quick follow ups (#2813)
  BSK bump for iOS RMF updates (#2798)
  Autofill engagement KPIs for pixel reporting (#2806)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Jun 4, 2024
* main:
  Add optional "multiple" property to PageElement (#2827)
  Update BSK for iOS RMF changes (#2831)
  Bump version to 1.91.0 (197)
  Set marketing version to 1.91.0
  Update embedded files
  DBP: Enable DBP Operations to Run When Device is Locked (#2797)
  Update autoconsent to v10.9.0 (#2822)
  Bump version to 1.90.0 (196)
  Revert "Add PIPAgent entitlement (#2821)" (#2823)
  Bump version to 1.90.0 (195)
  Bump version to 1.90.0 (194)
  Add PIPAgent entitlement (#2821)
  Fixes some VPN uninstallation issues (#2820)
  Bump version to 1.90.0 (193)
  Remove autofill survey (#2819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants