Update Gemfile to use fastlane fork #1537
Merged
+65
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loremattei
approved these changes
Aug 28, 2023
samsymons
added a commit
that referenced
this pull request
Aug 30, 2023
# By Diego Rey Mendez (4) and others # Via Diego Rey Mendez * develop: Fixes the BSK version manually #3 Fixes the BSK version manually #2 Fixes the BSK version manually Fix auth token issues (#1563) Bye Catalina (#1501) exempt apps.facebook.com & standard.co.uk for CTL (#1505) Update Gemfile to use fastlane fork (#1537) PopUp window positioning (#1551) Fix AdClickAttribution Mock causing test failures (#1538) Bump version to 1.54.0 (55) Update embedded files Show privacy dashboard for duckduckgo serp (#1521) Use unencrypted password for deduplicated Credentials objects (#1554) DBP: Add missing selector properties to CCF (#1555) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203301625297703/1203772337302927/f
Description:
Update to DDG's fork with a fix for fastlane/fastlane#21003
Steps to test this PR:
We'll really be able to test it while releasing, but for now you can e.g. try
bundle exec fastlane release_testflight, having previously commented out theupload_to_testflightline so that it only builds the app.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation