-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New improved way how we collect feedback reports and breakage reports
- Loading branch information
1 parent
eb24a6e
commit f2ce3e9
Showing
16 changed files
with
1,056 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
DuckDuckGo/Assets.xcassets/Images/ThankYou.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "ThankYou.pdf", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // | ||
| // Feedback.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import Foundation | ||
| import QuartzCore | ||
|
|
||
| struct Feedback { | ||
|
|
||
| enum Category { | ||
| case bug | ||
| case featureRequest | ||
| case other | ||
| } | ||
|
|
||
| let category: Category | ||
| let comment: String | ||
| let appVersion: String | ||
| let osVersion: String | ||
|
|
||
| } |
55 changes: 55 additions & 0 deletions
55
DuckDuckGo/Feedback and Breakage/Model/FeedbackSender.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // | ||
| // FeedbackSender.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import Foundation | ||
| import os.log | ||
|
|
||
| final class FeedbackSender { | ||
|
|
||
| static let feedbackURL = URL(string: "https://duckduckgo.com/feedback.js")! | ||
|
|
||
| func sendFeedback(_ feedback: Feedback) { | ||
| let parameters = [ | ||
| "type": "app-feedback", | ||
| "comment": feedback.comment, | ||
| "category": feedback.category.asanaId, | ||
| "osversion": feedback.osVersion, | ||
| "appversion": feedback.appVersion | ||
| ] | ||
|
|
||
| APIRequest.request(url: Self.feedbackURL, method: .post, parameters: parameters) { _, error in | ||
| if let error = error { | ||
| os_log("FeedbackSender: Failed to submit feedback %s", type: .error, error.localizedDescription) | ||
| Pixel.fire(.debug(event: .feedbackReportingFailed, error: error)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| fileprivate extension Feedback.Category { | ||
|
|
||
| var asanaId: String { | ||
| switch self { | ||
| case .bug: return "1199184518165816" | ||
| case .featureRequest: return "1199184518165815" | ||
| case .other: return "1200574389728916" | ||
| } | ||
| } | ||
|
|
||
| } |
41 changes: 41 additions & 0 deletions
41
DuckDuckGo/Feedback and Breakage/Model/WebsiteBreakage.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // | ||
| // WebsiteBreakage.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct WebsiteBreakage { | ||
|
|
||
| enum Category: String, CaseIterable { | ||
| case cantSignIn = "login" | ||
| case contentIsMissing = "content" | ||
| case linksDontWork = "links" | ||
| case browserIsIncompatible = "unsupported" | ||
| case theSiteAskedToDisable = "paywall" | ||
| case videoOrImagesDidntLoad = "images" | ||
| case somethingElse = "other" | ||
| } | ||
|
|
||
| let category: Category? | ||
| let siteUrlString: String | ||
| let osVersion: String | ||
| let upgradedHttps: Bool | ||
| let tdsETag: String? | ||
| let blockedTrackerDomains: [String] | ||
| let installedSurrogates: [String] | ||
|
|
||
| } |
36 changes: 36 additions & 0 deletions
36
DuckDuckGo/Feedback and Breakage/Model/WebsiteBreakageSender.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // | ||
| // WebsiteBreakageSender.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| final class WebsiteBreakageSender { | ||
|
|
||
| func sendWebsiteBreakage(_ websiteBreakage: WebsiteBreakage) { | ||
| let parameters: [String: String] = ["category": websiteBreakage.category?.rawValue ?? "", | ||
| "siteUrl": websiteBreakage.siteUrlString, | ||
| "upgradedHttps": websiteBreakage.upgradedHttps ? "true" : "false", | ||
| "tds": websiteBreakage.tdsETag?.trimmingCharacters(in: CharacterSet(charactersIn: "\"")) ?? "", | ||
| "blockedTrackers": websiteBreakage.blockedTrackerDomains.joined(separator: ","), | ||
| "surrogates": websiteBreakage.installedSurrogates.joined(separator: ","), | ||
| "os": websiteBreakage.osVersion, | ||
| "manufacturer": "Apple"] | ||
|
|
||
| Pixel.fire(.brokenSiteReport, withAdditionalParameters: parameters) | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.