Fix synchronous data removal from PixelDataStore cache (#382)

duckduckgo · Dec 29, 2021 · 6dfc471 · 6dfc471
1 parent 7a69dfc
commit 6dfc471
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/DuckDuckGo/Statistics/PixelDataStore.swift b/DuckDuckGo/Statistics/PixelDataStore.swift
@@ -164,6 +164,7 @@ final class LocalPixelDataStore<T: NSManagedObject>: PixelDataStore {
     }
 
     func removeValue(forKey key: String, completionHandler: ((Error?) -> Void)?) {
+        self.cache.removeValue(forKey: key)
         let predicate = self.predicate(forKey: key)
 
         func mainQueueCompletion(_ error: Error?) {
@@ -185,8 +186,6 @@ final class LocalPixelDataStore<T: NSManagedObject>: PixelDataStore {
                 let changes: [AnyHashable: Any] = [NSDeletedObjectsKey: deletedObjects]
                 NSManagedObjectContext.mergeChanges(fromRemoteContextSave: changes, into: [context])
 
-                self.cache.removeValue(forKey: key)
-
                 mainQueueCompletion(nil)
             } catch {
                 mainQueueCompletion(error)