Update BSK Ref

duckduckgo · Jan 29, 2025 · 21b8492 · 21b8492
1 parent 0c36e22
commit 21b8492
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/DuckDuckGo-macOS.xcodeproj/project.pbxproj b/DuckDuckGo-macOS.xcodeproj/project.pbxproj
@@ -15374,8 +15374,8 @@
 			isa = XCRemoteSwiftPackageReference;
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
-				kind = exactVersion;
-				version = 232.1.0;
+				branch = "alessandro/malicious-site-protection-ios";
+				kind = branch;
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,17 +32,17 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/BrowserServicesKit",
       "state" : {
-        "revision" : "e00b4ac4002bb5906e4ed63457aca4f920979c80",
-        "version" : "232.1.0"
+        "branch" : "alessandro/malicious-site-protection-ios",
+        "revision" : "33c141b3e8a467dbc9fe95b5333d8f07631fe6c4"
       }
     },
     {
       "identity" : "content-scope-scripts",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/content-scope-scripts",
       "state" : {
-        "revision" : "181696656f3627c1b3ca8cda06d54971e03436ef",
-        "version" : "7.10.0"
+        "revision" : "5a463e35ce86fc11394fe62392d32960de22f7d7",
+        "version" : "7.11.0"
       }
     },
     {

diff --git a/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift b/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift
@@ -153,6 +153,9 @@ public class MaliciousSiteProtectionManager: MaliciousSiteDetecting {
             PixelKit.fire(event)
         case .matchesApiFailure(let error):
             Logger.maliciousSiteProtection.error("Error fetching matches from API: \(error)")
+        case .failedToDownloadInitialDataSets:
+            // `.failedToDownloadInitialDataSets` Pixel is sent within the BSK library
+            break
         }
     }
 

diff --git a/UnitTests/MaliciousSiteProtection/Mocks/MaliciousSiteProtectionMocks.swift b/UnitTests/MaliciousSiteProtection/Mocks/MaliciousSiteProtectionMocks.swift
@@ -70,10 +70,9 @@ class MockMaliciousSiteFileStore: MaliciousSiteProtection.FileStoring {
     var didWriteToDisk: Bool = false
     var didReadFromDisk: Bool = false
 
-    func write(data: Data, to filename: String) -> Bool {
+    func write(data: Data, to filename: String) throws {
         didWriteToDisk = true
         storage[filename] = data
-        return true
     }
 
     func read(from filename: String) -> Data? {