Run ESLint on scripts #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
jkt/eslint
branch
from
ca09022 to
28d56f9
Compare
jonathanKingston
requested review from
brindy,
bwaresiak,
samsymons and
THISISDINOSAUR
as code owners
jonathanKingston
force-pushed
the
jkt/eslint
branch
from
28d56f9 to
602ff34
Compare
jonathanKingston
force-pushed
the
jkt/eslint
branch
3 times, most recently
from
5712205 to
6825cfd
Compare
bwaresiak
reviewed
Oct 28, 2021
|
@jonathanKingston Is there a task related to this? Maybe with some description about expected benefits and usage, so it can be linked to our documentation :) |
|
The specific task for this is: https://app.asana.com/0/414235014887631/1201233794429574/f and the parent task explains the background: https://app.asana.com/0/414709148257752/1199918087656627/f The JS project page also has motivations and maintains platform status on this: https://app.asana.com/0/1201203727797217/1201203750243780/f |
- Add a package.json - Change replacements to be valid JS which makes lint run fine - Add automation test (hopefully)
jonathanKingston
force-pushed
the
jkt/eslint
branch
from
6825cfd to
8d610fb
Compare
7 tasks
1 task
samsymons
added a commit
that referenced
this pull request
Nov 27, 2021
* develop: Stop web views from loading during Fire button calls (#1010) Fix `Unprotected Sites` toolbar was kept hidden. (#990) Add a check for the Homebrew location on M1 Macs. (#1000) Bump version number Fixes and enhanced stats for recently added debug pixel (#1007) Fix Core Data deadlocks (#989) Update version number Improvements to cookie cleaning (#1002) Remove unused TrackingProtectionStats dead code (#996) Update version Update version number Update TDS dependency after latest release (#995) Support for Tracker Exceptions (#991) Use temp unprotected list and user list for all features (#993) Run ESLint on scripts (#984) Move to using mutation observing to reduce page overhead (#985) Disabling SafeBrowsing due to privacy implications (#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1201233794429574/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
2.
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM