Old to new onboarding migration fix

[alessandroboron]

Task/Issue URL: https://app.asana.com/0/0/1209336232176393/f

Description:

This PR add a fix to set the onboarding Dax Dialogs hidden when the user updates the App if the saw the old onboarding and they haven’t seen some of the dialogs. More info in Asana Task

🎥 Video of the Fix

Old onboarding fresh install:

old_onboarding_to_be_fixed.mp4

Updating the App does not show any dax dialog:

new_onboarding_fixed.mp4

Steps to test this PR:

1. Remove the DDG App from the simulator.
2. Checkout branch origin/alessandro/old-onboarding. This is branched off tag 7.130.-2 and include a fix to make it compile with Xcode 16.2.
3. Launch the App.
4. Wait for Onboarding to Appear.
5. Tap the “Let’s Do It” button on the first screen..
6. When Make DuckDuckGo your default Browser Appear tap the “Skip” button.
7. When Dax Dialog appear on screen asking to navigate to one of your favourite sites, navigate to duckduckgo.com
8. When the ’no blocked tracker’ dialog appears on screen, tap the “Got It” button.
9. Tap the Fire button.
   10.Tap the “Close Tabs and Clear Data” button.
10. Wait for the “end of journey” (You Got this!) dialogs to appear on screen.
11. Kill the App.
12. Switch to origin/alessandro/old-to-new-onboarding-migration-fix branch.
13. Launch the App.
14. Ensure that no new dax dialogs are shown in the new tab page.
15. Navigate to bbc.com
16. Ensure no dax dialogs are shown.
17. Navigate to facebook.com
18. Ensure no dax dialogs are shown.
19. Navigate to duckduckgo.com
20. Ensure no dax dialogs are shown.
21. Clear data using the fire button.
22. Ensure no end of journey dialog is shown in the new tab page appearing.

Definition of Done (Internal Only):

• Does this PR satisfy our Definition of Done?

Copy Testing:

• Use of correct apostrophes in new copy, ie ’ rather than ’

Orientation Testing:

• Portrait
• Landscape

Device Testing:

• iPhone SE (1st Gen)
• iPhone 8
• iPhone X
• iPhone 14 Pro
• iPad

OS Testing:

• iOS 15
• iOS 16
• iOS 17

Theme Testing:

• Light theme
• Dark theme

—

Internal references:

Software Engineering Expectations
Technical Design Template

[brindy]

LGTM! Nice. Note there's a failing test, but it's fixed on main so don't worry.

I wasn't able to merge because Asana is down and I don't know how this would affect the automations.