Duckplayer: 33. Fix video auto-pause issues #3929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1209253933548270
Tech Design URL:
CC:
Description:
In some cases, when watching videos in DuckPlayer, videos pause after a few seconds when in Always Ask mode.
The issue involves a backgrounded tab. Although our JavaScript pauses the video every 10 ms, YouTube attempts to play an ad and succeeds. The ad plays briefly before our JavaScript pauses it, which is enough to hijack the audio session from the Duckplayer view, pausing the video.
This fix mutes the opener tab audio if "Open in new tab" is enabled. Thus, even if an ad plays briefly, it doesn't steal the audio session.
Steps to test this PR:
mkbhd
Definition of Done (Internal Only):
—
Internal references:
Software Engineering Expectations
Technical Design Template