Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace from task URL in PR Task URL workflow #3922

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Feb 3, 2025

Task/Issue URL: https://app.asana.com/0/1203301625297703/1209311684037783

Steps to test this PR:
Verify that this task is properly added to App Board by automation.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from Bunn February 3, 2025 21:42
@ayoy ayoy force-pushed the dominik/fix-pr-task-url branch from 75a6476 to 6c927a9 Compare February 3, 2025 21:45
@Bunn Bunn merged commit 0001eaf into main Feb 4, 2025
13 checks passed
@Bunn Bunn deleted the dominik/fix-pr-task-url branch February 4, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants