DuckPlayer Native PoC: Webview storage + nav coordination #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo/DuckPlayer/DuckPlayer.swift
# Conflicts: # DuckDuckGo-iOS.xcodeproj/project.pbxproj # DuckDuckGo/DuckPlayer/DuckPlayer.swift # DuckDuckGo/DuckPlayer/DuckPlayerView.swift
afterxleep
changed the base branch from
main
to
daniel/duckplayer/29.defaults.removal
afterxleep
changed the base branch from
daniel/duckplayer/29.defaults.removal
to
main
afterxleep
commented
Jan 31, 2025
| @@ -109,28 +105,3 @@ struct DuckPlayerView: View { | |||
| .background(Color.black) | |||
| } | |||
| } | |||
|
|
|||
| // WebView wrapper for WKWebView | |||
There was a problem hiding this comment.
Moved into a separate type-
afterxleep
commented
Jan 31, 2025
| } | ||
|
|
||
| func makeUIView(context: Context) -> WKWebView { | ||
| let configuration = WKWebViewConfiguration() |
There was a problem hiding this comment.
Added a bunch of privacy protections, and removed persistent storage
afterxleep
commented
Jan 31, 2025
|
|
||
| func webView(_ webView: WKWebView, createWebViewWith configuration: WKWebViewConfiguration, for navigationAction: WKNavigationAction, windowFeatures: WKWindowFeatures) -> WKWebView? { | ||
| // Prevent automatic opening of URLs in browser | ||
| if let url = navigationAction.request.url { |
There was a problem hiding this comment.
Disallow window creation and other navigation
Bunn
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209280272427911/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
[DuckPlayer] Navigation request to <URL>log message, but nothing should happen[DuckPlayer] Navigation request to <URL>log message when tapping “Watch in Youtube” thereDefinition of Done (Internal Only):