Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone submodule when running PR checks #3900

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jan 31, 2025

Task/Issue URL: https://app.asana.com/0/414235014887631/1209287106283250/f
Tech Design URL:
CC:

Description:

This PR tests a submodule workflow change, after seeing previous runs where submodules weren't fetched and the tests failed due to missing submodule files.

Steps to test this PR:

  1. Check that CI is green

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons changed the title Test submodule change Clone submodule when running PR checks Jan 31, 2025
@samsymons samsymons marked this pull request as ready for review January 31, 2025 01:27
@samsymons samsymons merged commit 3a08906 into main Jan 31, 2025
29 checks passed
@samsymons samsymons deleted the sam/fetch-submodules-during-pr-checks branch January 31, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants