Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking out the code for PR checks run on PRs #3899

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 30, 2025

Task/Issue URL: https://app.asana.com/0/1203301625297703/1209272520947602/f

Description:
Don't pass ref argument to checkout action for runs on pull request / push.

Steps to test this PR:

  1. Verify that PR Checks workflow gets past "Check out the code" step.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from afterxleep January 30, 2025 11:06
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when the CI is green. Thanks!

@ayoy ayoy merged commit e847b86 into main Jan 30, 2025
19 of 20 checks passed
@ayoy ayoy deleted the dominik/fix-pr-checks branch January 30, 2025 11:38
ayoy added a commit that referenced this pull request Jan 30, 2025
Task/Issue URL: https://app.asana.com/0/1203301625297703/1209272520947602/f

Description:
Don't pass ref argument to checkout action for runs on pull request / push.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants